Bluetooth: controller: Refactor ll c into states/roles files #15

cvinayak · 2017-04-29T13:49:55Z

Collection of commit to refactor ll.c file.

This change is

cvinayak · 2017-05-02T11:41:04Z

@jhedberg @carlescufi @Vudentz Please do the needful!

The current implementation of stm32_gpio_set() uses the GPIO output data register to change the state of individual GPIOs. The generated assembler needs at least 3 instructions: load / modify / store. This opens a small race window, for example if a thread and an interrupt both try to change the state of the same GPIO bank. Use the GPIO bit set/reset register to perform the atomic change without locking. This also has the benefit of a more optimised implementation, which can be useful for GPIO-intensive work. Compare the new version: 08000c98 <stm32_gpio_set>: 8000c98: f001 010f and.w r1, r1, zephyrproject-rtos#15 8000c9c: 2301 movs r3, zephyrproject-rtos#1 8000c9e: b902 cbnz r2, 8000ca2 <stm32_gpio_set+0xa> 8000ca0: 3110 adds r1, zephyrproject-rtos#16 8000ca2: 408b lsls r3, r1 8000ca4: 6183 str r3, [r0, zephyrproject-rtos#24] 8000ca6: 2000 movs r0, #0 8000ca8: 4770 bx lr and the old one: 08000c98 <stm32_gpio_set>: 8000c98: 2301 movs r3, zephyrproject-rtos#1 8000c9a: f001 010f and.w r1, r1, zephyrproject-rtos#15 8000c9e: fa03 f101 lsl.w r1, r3, r1 8000ca2: 6943 ldr r3, [r0, zephyrproject-rtos#20] 8000ca4: b10a cbz r2, 8000caa <stm32_gpio_set+0x12> 8000ca6: 4319 orrs r1, r3 8000ca8: e001 b.n 8000cae <stm32_gpio_set+0x16> 8000caa: ea23 0101 bic.w r1, r3, r1 8000cae: 6141 str r1, [r0, zephyrproject-rtos#20] 8000cb0: 2000 movs r0, #0 8000cb2: 4770 bx lr Change-Id: Ie5800d1c345016028d1b9a099f5d74cac35f592a Signed-off-by: Florian Vaussard <[email protected]>

jhedberg · 2017-05-04T07:10:49Z

subsys/bluetooth/controller/hci/hci.c

 	case BT_OCF(BT_HCI_OP_LE_CONN_UPDATE):
 		le_conn_update(cmd, evt);
 		break;

+#if defined(CONFIG_BLUETOOTH_CONTROLLER_ROLE_MASTER)


Could you try to reorder the case statments so that each #if-#endif pair only appears once?

Sure.

Lets see if this comment is lost!

No this review/comment is not lost when doing git push -f.

In preparation for refactoring the Controller implementation into seperate state and role based source files, add Kconfig options for states and roles in the Controller. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Move advertising state related implementation out into a separate ll_adv.c file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Move scanning state related implementation out into a separate ll_scan.c file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Move master role related implementation out into a separate ll_master.c file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Conditionally compile slave role related HCI commands. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Conditionally compile connection state related HCI commands. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

[AIO] Fixed incorrect comments in in AIO sample js

* Modified SoC init function configures COP WDT to time out after 8192ms if CONFIG_WATCHDOG is set. * A demo application shows how the WDT must be reloaded in order not to time out. * Closes zephyrproject-rtos#15

feat: WDT: added WDT demo application Closes zephyrproject-rtos#15 See merge request blik/embedded/zephyr!25

Set of latest patches

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write zephyrproject-rtos#1: 16 bytes (0 bps) Write zephyrproject-rtos#2: 32 bytes (3445948416 bps) Write zephyrproject-rtos#3: 48 bytes (2596929536 bps) Write zephyrproject-rtos#4: 64 bytes (6400 bps) Write zephyrproject-rtos#5: 80 bytes (8533 bps) Write zephyrproject-rtos#6: 96 bytes (10666 bps) Write zephyrproject-rtos#7: 112 bytes (8533 bps) Write zephyrproject-rtos#8: 128 bytes (9955 bps) Write zephyrproject-rtos#9: 144 bytes (11377 bps) Write zephyrproject-rtos#10: 160 bytes (7680 bps) Write zephyrproject-rtos#11: 176 bytes (8533 bps) Write zephyrproject-rtos#12: 192 bytes (9386 bps) Write Complete (err 0) Write zephyrproject-rtos#13: 208 bytes (8533 bps) Write zephyrproject-rtos#14: 224 bytes (9244 bps) Write zephyrproject-rtos#15: 240 bytes (9955 bps) Write zephyrproject-rtos#16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <[email protected]>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write #1: 16 bytes (0 bps) Write #2: 32 bytes (3445948416 bps) Write #3: 48 bytes (2596929536 bps) Write #4: 64 bytes (6400 bps) Write #5: 80 bytes (8533 bps) Write #6: 96 bytes (10666 bps) Write #7: 112 bytes (8533 bps) Write #8: 128 bytes (9955 bps) Write #9: 144 bytes (11377 bps) Write #10: 160 bytes (7680 bps) Write #11: 176 bytes (8533 bps) Write #12: 192 bytes (9386 bps) Write Complete (err 0) Write #13: 208 bytes (8533 bps) Write #14: 224 bytes (9244 bps) Write #15: 240 bytes (9955 bps) Write #16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <[email protected]>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write zephyrproject-rtos#1: 16 bytes (0 bps) Write zephyrproject-rtos#2: 32 bytes (3445948416 bps) Write zephyrproject-rtos#3: 48 bytes (2596929536 bps) Write zephyrproject-rtos#4: 64 bytes (6400 bps) Write zephyrproject-rtos#5: 80 bytes (8533 bps) Write zephyrproject-rtos#6: 96 bytes (10666 bps) Write zephyrproject-rtos#7: 112 bytes (8533 bps) Write zephyrproject-rtos#8: 128 bytes (9955 bps) Write zephyrproject-rtos#9: 144 bytes (11377 bps) Write zephyrproject-rtos#10: 160 bytes (7680 bps) Write zephyrproject-rtos#11: 176 bytes (8533 bps) Write zephyrproject-rtos#12: 192 bytes (9386 bps) Write Complete (err 0) Write zephyrproject-rtos#13: 208 bytes (8533 bps) Write zephyrproject-rtos#14: 224 bytes (9244 bps) Write zephyrproject-rtos#15: 240 bytes (9955 bps) Write zephyrproject-rtos#16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <[email protected]>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write #1: 16 bytes (0 bps) Write #2: 32 bytes (3445948416 bps) Write #3: 48 bytes (2596929536 bps) Write #4: 64 bytes (6400 bps) Write #5: 80 bytes (8533 bps) Write #6: 96 bytes (10666 bps) Write #7: 112 bytes (8533 bps) Write #8: 128 bytes (9955 bps) Write #9: 144 bytes (11377 bps) Write #10: 160 bytes (7680 bps) Write #11: 176 bytes (8533 bps) Write #12: 192 bytes (9386 bps) Write Complete (err 0) Write #13: 208 bytes (8533 bps) Write #14: 224 bytes (9244 bps) Write #15: 240 bytes (9955 bps) Write #16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <[email protected]>

[BUG zephyrproject-rtos#2882] arch: arm64: core: Add IPI for system halt

…r zephyrproject-rtos/lvgl

- Minor cleanup, tweaks to tag_main.sh. - Added the pr_comment.sh script * writes a comment to a PR with the rebase tag info * Works for both zephyr and zephyr-intel manifest update PRs Signed-off-by: Connor Graydon <[email protected]>

…rproject-rtos#15) Do not re-init PLLs after already being initialized Approved-by: Fabian van den IJssel Approved-by: Chris Desjardins

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from fd12640 to 8c78e32 Compare April 29, 2017 14:21

jhedberg force-pushed the bluetooth branch from 1914fc3 to e588ca0 Compare May 1, 2017 12:55

jhedberg requested a review from Vudentz May 1, 2017 14:08

Vudentz previously approved these changes May 1, 2017

View reviewed changes

cvinayak changed the base branch from bluetooth to master May 1, 2017 18:37

jhedberg assigned carlescufi May 2, 2017

jhedberg requested a review from carlescufi May 2, 2017 05:31

carlescufi previously approved these changes May 2, 2017

View reviewed changes

jhedberg self-requested a review May 2, 2017 10:05

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from 8c78e32 to caad338 Compare May 2, 2017 11:38

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from caad338 to 19c80cb Compare May 3, 2017 13:50

cvinayak dismissed carlescufi’s stale review via 8ff2b85 May 4, 2017 06:30

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from 19c80cb to 8ff2b85 Compare May 4, 2017 06:30

jhedberg reviewed May 4, 2017

View reviewed changes

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch 2 times, most recently from aac5133 to 776a426 Compare May 4, 2017 10:06

cvinayak added 6 commits May 4, 2017 19:43

Bluetooth: controller: Refactor LL Adv state to ll_adv.c file

afbcfad

Move advertising state related implementation out into a separate ll_adv.c file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Bluetooth: controller: Refactor LL Scan state to ll_scan.c file

1e697af

Move scanning state related implementation out into a separate ll_scan.c file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Bluetooth: controller: Refactor LL Master role to ll_master.c

1f0df0d

Move master role related implementation out into a separate ll_master.c file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Bluetooth: controller: Conditionally compile slave role HCI cmds

5ee00fd

Conditionally compile slave role related HCI commands. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Bluetooth: controller: Cond. compile connection state HCI cmds

1433b32

Conditionally compile connection state related HCI commands. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

cvinayak dismissed Vudentz’s stale review via 1433b32 May 4, 2017 18:34

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from 776a426 to 1433b32 Compare May 4, 2017 18:34

jhedberg approved these changes May 5, 2017

View reviewed changes

Merge branch 'master' into github_bluetooth_refactor_ll_c

e34363e

carlescufi approved these changes May 5, 2017

View reviewed changes

Merge branch 'master' into github_bluetooth_refactor_ll_c

6e778d0

This was referenced Sep 23, 2017

Disabling advertising gets stuck #3774

Closed

NULL pointer read in udp, tcp, context net tests #3800

Closed

nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017

Merge pull request zephyrproject-rtos#15 from jimmy-huang/master

2f2f81b

[AIO] Fixed incorrect comments in in AIO sample js

mike-scott mentioned this pull request Jun 5, 2018

scheduler: threads using k_sleep can be _swap()'d back too early #8128

Closed

frasa added a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019

Merge branch 'feat-watchdog' into 'dev'

83987a0

feat: WDT: added WDT demo application Closes zephyrproject-rtos#15 See merge request blik/embedded/zephyr!25

xiaoliang314 mentioned this pull request Jun 17, 2019

Bluetooth: Mesh: Rx buffer exhaustion causes deadlock #16864

Closed

xiaoliang314 mentioned this pull request Jun 26, 2019

Bluetooth: Fix various deadlock issues when running low on buffers #16870

Closed

finikorg pushed a commit to finikorg/zephyr that referenced this pull request Oct 25, 2019

Merge pull request zephyrproject-rtos#15 from finikorg/for-upstream2

92a128c

Set of latest patches

anchao mentioned this pull request Jul 30, 2020

Bluetooth: Mesh: Fix tx seg buffer with NULL pointer reference #27251

Merged

stephanosio mentioned this pull request Jun 24, 2021

lib/gui/lvgl: Add user config file #36479

Closed

fkan-ec pushed a commit to fkan-ec/zephyr that referenced this pull request Jan 17, 2022

Merge pull request zephyrproject-rtos#15 from ec-platform-sw/BUG_2882

21ca5e6

[BUG zephyrproject-rtos#2882] arch: arm64: core: Add IPI for system halt

RafaelLeeImg mentioned this pull request Jan 19, 2022

Kernel usage fault when using semaphore with multi-threading #41963

Closed

gigiduck pushed a commit to gigiduck/zephyr that referenced this pull request Feb 7, 2022

Sideloaded lvgl v8 from repo in pull request zephyrproject-rtos#15 fo…

17a4ad7

…r zephyrproject-rtos/lvgl

piotrParf mentioned this pull request Feb 9, 2022

BLE Testing functions do not work properly #42534

Closed

dleach02 mentioned this pull request Oct 19, 2022

hal: nxp: ARRAY_SIZE collision #51371

Closed

NickolasLapp pushed a commit to NickolasLapp/zephyr that referenced this pull request Oct 19, 2022

[LFS] Fixing mount error reporting (zephyrproject-rtos#15)

5ca7e7f

dleach02 mentioned this pull request Oct 19, 2022

sys: util: Prevent multiple definitions of ARRAY_SIZE #50239

Closed

sjanc mentioned this pull request May 16, 2023

Assert when executing GATT/SR/GAW/BV-14-C test #57930

Closed

DavidCPlatt mentioned this pull request Dec 7, 2024

RP2040 (Raspberry Pi Pico) fails to start up - code clobbered or XIP-flash inaccessible? #82632

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bluetooth: controller: Refactor ll c into states/roles files #15

Bluetooth: controller: Refactor ll c into states/roles files #15

cvinayak commented Apr 29, 2017 •

edited by galak

Loading

cvinayak commented May 2, 2017

jhedberg May 4, 2017

cvinayak May 4, 2017

cvinayak May 4, 2017

Bluetooth: controller: Refactor ll c into states/roles files #15

Bluetooth: controller: Refactor ll c into states/roles files #15

Conversation

cvinayak commented Apr 29, 2017 • edited by galak Loading

cvinayak commented May 2, 2017

jhedberg May 4, 2017

Choose a reason for hiding this comment

cvinayak May 4, 2017

Choose a reason for hiding this comment

cvinayak May 4, 2017

Choose a reason for hiding this comment

cvinayak commented Apr 29, 2017 •

edited by galak

Loading